GitHub actions minimal #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatol Belski <[email protected]>
The replace const or replace with QM_ASSIGN pattern is common to all constant folding, extract it into a function.
…tion Nowadays self::X is represented using an UNUSED operand with FETCH_CLASS_SELF flag rather than a separate FETCH_CLASS instruction. The code already handles the new pattern.
This handles references to the current class through its name rather than self (and for cases where is is not linked yet and thus not covered by the context lookup). Rather than handling this only for FETCH_CLASS_CONSTANT optimization, integrate this into the generic get_class_entry() utility.
Export and reuse this helper in places that fetch a class entry from op1.
Move literal destruction into helper and use a common result variable to make code more compact.
These can be handled by the generic code. Worth noting that count will usually go through ZEND_COUNT, and chr on constants is evaluated in the compiler, so these are not particularly compile-time sensitive either.
Both tests fail on Windows for slightly different reasons, what appears to be legit, and as such we fix the test expectations. Closes phpGH-7830.
* PHP-8.0: Fix chunk_split_variation*_32bit.phpt for Windows
* PHP-8.1: Fix chunk_split_variation*_32bit.phpt for Windows
…_file Like `hash_file()`, `hash_hmac_file()` expects a filename, and not some string data. Fixing this now, constitutes a (hopefully small) BC break though. Closes phpGH-7828.
* PHP-8.0: Fix phpGH-7826: Inconsistent argument name in hash_hmac_file and hash_file
* PHP-8.1: Fix phpGH-7826: Inconsistent argument name in hash_hmac_file and hash_file
Pass1 handles a number of special functions that can be evaluated under some circumstances. Move the core logic into a separate helper, as I believe that SCCP should reuse this.
Move evaluation of ini_get() into eval_special_func_call() and use this helper both in pass1 and sccp.
This header declaration is never supposed to be interpreted as definition; otherwise, the handlers are not properly initialized, what happens, for instance, with ASan instrumented MSVC builds. Closes phpGH-7827.
* PHP-8.0: Prevent strict interpretation of tentative definition
* PHP-8.1: Prevent strict interpretation of tentative definition
* PHP-8.1: Bump for 8.1.4-dev
If an output handler has not yet been started, calling `ob_clean()` causes it to start. If that happens, we must not forget to set the `Content-Encoding` and `Vary` headers. Closes phpGH-7960.
* PHP-8.0: Fix phpGH-7953: ob_clean() only does not set Content-Encoding
* PHP-8.1: Fix phpGH-7953: ob_clean() only does not set Content-Encoding
`error: comparison of integer expressions of different signedness: ‘size_t’ {aka
‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]`
This is asserting `end >= haystack` as a precondition for callers (in debug
builds) and existing callers are correct.
An alternate option is to cast the left side to `int64_t`, but that may be
slightly inefficient for 32-bit builds.
* PHP-8.0: Haiku fix ZTS build, disabling tls model
* PHP-8.1: Haiku fix ZTS build, disabling tls model
We need to reset the shift state right after conversion, to cater to potenially following plain encodings. Also, there is no need to reset the shift for plain encodings, because these are not state-dependent. Closes phpGH-8025.
* PHP-8.0: Fix phpGH-7980: Unexpected result for iconv_mime_decode
* PHP-8.1: Fix phpGH-7980: Unexpected result for iconv_mime_decode
Expand ZE to Zend Engine and remove Zend Engine version. per Christoph M. Becker's comment for PR-8008. Signed-off-by: Su, Tao <[email protected]> Closes phpGH-8057.
We enable interlace transform when reading png. Closes phpGH-8002.
* PHP-8.0: Fixed libpng warning when loading interlaced images
* PHP-8.1: Fixed libpng warning when loading interlaced images
* PHP-8.0: Free cached chunks when the requested memory limit is above real usage
* PHP-8.1: Free cached chunks when the requested memory limit is above real usage
* PHP-8.1: [ci skip] news Fix phpGH-8059 use $PHP_EXECUTABLE when $PHP not set
iluuu1994
force-pushed
the
github-actions-minimal
branch
from
7d1041e to
d7473be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.