Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: isaacs/node-glob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.0.1
Choose a base ref
...
head repository: isaacs/node-glob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.1.0
Choose a head ref
  • 20 commits
  • 14 files changed
  • 6 contributors

Commits on Apr 23, 2025

  1. Configuration menu
    Copy the full SHA
    2ffd918 View commit details
    Browse the repository at this point in the history
  2. 11.0.2

    isaacs committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    fd61f24 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2025

  1. update all deps

    isaacs committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    af3d7e1 View commit details
    Browse the repository at this point in the history
  2. ci: update action versions

    isaacs committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    4f998c0 View commit details
    Browse the repository at this point in the history
  3. 11.0.3

    isaacs committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    af2e7ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6cb281d View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2025

  1. Configuration menu
    Copy the full SHA
    93e56e9 View commit details
    Browse the repository at this point in the history
  2. update deps

    isaacs committed Sep 23, 2025
    Configuration menu
    Copy the full SHA
    de6479f View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2025

  1. Blue Oak license

    isaacs committed Oct 25, 2025
    Configuration menu
    Copy the full SHA
    780735e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2025

  1. update workflows and deps

    isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    de93864 View commit details
    Browse the repository at this point in the history
  2. fix typo mathspaths

    PR-URL: #631
    Credit: @JamBalaya56562
    Close: #631
    Reviewed-by: @isaacs
    JamBalaya56562 authored and isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    7e190e8 View commit details
    Browse the repository at this point in the history
  3. fix repo url

    isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    1527e2b View commit details
    Browse the repository at this point in the history
  4. Fix punctuation in traversal function documentation

    Updated the traversal function documentation to maintain consistency in punctuation.
    
    PR-URL: #617
    Credit: @shaymolcho
    Close: #617
    Reviewed-by: @
    shaymolcho authored and isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    13e68ea View commit details
    Browse the repository at this point in the history
  5. fix: correct typos in README.md

    PR-URL: #613
    Credit: @spageektti
    Close: #613
    Reviewed-by: @isaacs
    spageektti authored and isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    c9773c2 View commit details
    Browse the repository at this point in the history
  6. docs: add better links to path-scurry docs

    PR-URL: #609
    Credit: @jedwards1211
    Close: #609
    Reviewed-by: @isaacs
    jedwards1211 authored and isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    0559b0e View commit details
    Browse the repository at this point in the history
  7. docs(README): add #anchor and improve notes

    PR-URL: #591
    Credit: @danielbayley
    Close: #591
    Reviewed-by: @6555lee
    danielbayley authored and isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    dde4fa6 View commit details
    Browse the repository at this point in the history
  8. fix notes

    isaacs committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    59bf9ca View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2025

  1. Configuration menu
    Copy the full SHA
    bc33fe1 View commit details
    Browse the repository at this point in the history
  2. bin: Do not expose filenames to shell expansion

    This resolves GHSA-5j98-mcp5-4vw2, with a minimum of breaking changes
    for as many users as possible.
    
    First, 'shell: true' is only used on the subprocess if set explicitly by
    the user in the command line, and only if it is not a shell where this
    can be avoided safely without any reduction in functionality. In this
    case, a deprecation warning is printed, telling them that it's unsafe,
    and that it will be removed in a future version.
    
    Second, as the only reason for such behavior was to be able to have
    commands that include positional arguments in the --cmd/-c value, a new
    option --cmd-arg/-g is added, so that users can pass positional
    arguments ahead of the file matches, in a way that does not rely on
    shell expansion.
    
    Lastly, as a general quality of life improvement which should keep this
    entire issue from even mildly inconveniencing most users, when the
    command contains space or quote characters (and thus, is likely to
    contain positional arguments), AND the `SHELL` environment variable
    refers to a shell program with a known way to pass positional arguments
    to the child process, then we use that technique, again avoiding shell
    expansion of the resolved file paths (or the user command itself). This
    applies to sh, ksh, bash, zsh, and fish.
    
    This potentially WILL break workflows, and require updating, if they are
    relying on the automatic shell expansion, in systems other than the
    known posix shells referenced above. The only likely case that anyone
    will thus encounter, is running commands on Windows. While there DOES
    appear to be a way to use a similar trick on Windows, but there are so
    many more edge cases, I'm not confident I can do so without introducing
    more bugs (and potentially more security issues).
    
    If users find that this breakage is too severe, the fix will be to roll
    out a subsequent release that turns `--shell` on by default on Windows,
    if the command contains space or quote characters.
    
    Nevertheless, v12 of this library will *not* contain a `--shell` option,
    and will not run child processes in `shell:true` mode under any
    circumstances.
    
    Note: this was simultaneously and independently reported by two
    researchers. My sincerest thanks for their time and attention.
    
    Reported-by: @Gyde04 "Babajide Emmanuel Fakile"
    Reported-by: @aisle-research "Pavel Kohout (Aisle Research)"
    Fix: GHSA-5j98-mcp5-4vw2
    Fix: CVE-2025-64756
    isaacs committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    47473c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2025

  1. 11.1.0

    isaacs committed Nov 17, 2025
    Configuration menu
    Copy the full SHA
    2551fb5 View commit details
    Browse the repository at this point in the history
Loading