Don't write empty probe arrays to exec files #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Godin May I ask for a review, please? |
Member
|
@marchof sure! This seems to be a huge improvement. Will do today. |
Member
Author
|
@Godin Thx, feel free to merge if you agree with the implementation. |
This optimizations reduces the size of exec files significantly in setups where execution data is dumped after every test case.
Member
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the mailing list it was proposed to not dump empty probe arrays to execution data files:
https://groups.google.com/forum/?fromgroups=#!topic/jacoco/wQhTVf2zEtI
In case of repeated dumps (per-test coverage) this can lead to a significant performance improvement:
Within JaCoCo there is no use for empty probe arrays vs. non existing ExecutionData entries. Therefore there is no need to dump such entries.