Fix for #8272 - Exceptions in plain JS object event handlers swallowed by jQuery #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the less try/catches the better. I ran this through the test suite in IE6 and everything passes. |
Member
|
daguej, thanks! Is the colon character the only one that causes the issue in IE? |
Author
|
Yes, the colon is the only problem character. Test here. Also, the IE bug that causes this problem is fixed in IE 9. |
Member
|
This try/catch no longer appears to be in the source - I think @dmethvin fixed this already. |
Member
|
Yep, i guess the PR didn't auto-close. The ticket did get closed though. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix implemented for #3533 caused a regression in jQuery 1.4.1 (and remains in 1.5). JavaScript exceptions thrown within a plain JS object's
on<event>handler get caught and swallowed by event.js:378.See #8272.