More did-you-mean errors on classes in plain JS

Classes
- that are declared with class declarations or expressions, but not
  constructor functions
- and which have nothing in their heritage clauses

Now provide spelling suggestions on misspelled property accesses.

Because of JS support for assignment-as-declaration, it's still easy
to mistakenly declare a property with a typo and not get any
suggestions.

Author: sandersn

src/compiler/checker.ts

@@ -29277,9 +29277,10 @@ m2: ${(this.mapper2 as unknown as DebugTypeMapper).__debugToString().split("\n")
             if (file) {
                 if (compilerOptions.checkJs === undefined && file.checkJsDirective === undefined && (file.scriptKind === ScriptKind.JS || file.scriptKind === ScriptKind.JSX)) {
                     const declarationFile = forEach(suggestion?.declarations, getSourceFileOfNode);
+                    const suggestionHasNoExtends = !suggestion?.valueDeclaration || !isClassLike(suggestion.valueDeclaration) || suggestion.valueDeclaration.heritageClauses?.length
                     return !(file !== declarationFile && !!declarationFile && isGlobalSourceFile(declarationFile))
-                        && !(excludeClasses && suggestion && suggestion.flags & SymbolFlags.Class)
-                        && !(!!node && excludeClasses && isPropertyAccessExpression(node) && node.expression.kind === SyntaxKind.ThisKeyword);
+                        && !(excludeClasses && suggestion && suggestion.flags & SymbolFlags.Class && suggestionHasNoExtends)
+                        && !(!!node && excludeClasses && isPropertyAccessExpression(node) && node.expression.kind === SyntaxKind.ThisKeyword && suggestionHasNoExtends);
                 }
             }
             return false;

tests/cases/fourslash/codeFixSpellingJs9.ts

@@ -1,10 +1,52 @@
 /// <reference path='fourslash.ts' />
+// @allowJs: true
+// @Filename: codeFixSpellingJs9.js
+//// class C {
+////     numble = 1
+////     mumble() {
+////         return this.[|numbles|]
+////     }
+//// }
+//// class D extends C { }
+//// const c = new C()
+//// c.[|numbles|] = 3
+//// c.[|mumbles|]()
+//// const d = new D()
+//// d.[|numbles|] = 4
+//// d.[|mumbles()|]
+//// class Person {
+////     getFavoriteColor() {
+////
+////     }
+//// }
+////
+//// const person = new Person();
+//// person.[|getFavoriteColour|]();
+//// person.[|getFavoriteColoxr|]();
+verify.codeFixAll({
+    fixId: "fixSpelling",
+    fixAllDescription: "Fix all detected spelling errors",
+    newFileContent:
+    `class C {
+    numble = 1
+    mumble() {
+        return this.numble
+    }
+}
+class D extends C { }
+const c = new C()
+c.numble = 3
+c.mumble()
+const d = new D()
+d.numbles = 4
+d.mumbles()
+class Person {
+    getFavoriteColor() {
 
-// @allowjs: true
-// @noEmit: true
+    }
+}
 
-// @filename: noSuggestionWithoutDidYouMean.js
-//// let a = {};
-//// console.log(a.apple);
-verify.noErrors()
-verify.getSuggestionDiagnostics([])
+const person = new Person();
+person.getFavoriteColor();
+person.getFavoriteColor();`,
+});