Speed up getAccessibleFileSystemEntries #36139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While writing a benchmark, I happened to notice that (a) the natural win32 APIs for this task include "isDirectory" in the result and (b) readDirSync will return entries, rather than strings, if you pass withFileTypes. It turns out this version, which allows us to dispense with path math and stat calls is ~30X faster (enumerating a directory with 600 children).
Member
|
Struggling to find an emoji to express my joy |
Member
Author
|
On Node 8 on Linux, the flag is ignored and strings are returned regardless. |
Member
Author
|
Node 10 on Linux shows a ~5X improvement, so it's probably worth finding a way to special case Node 8 on Linux. |
Contributor
|
There's already a PR to use |
Member
Author
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a benchmark, I happened to notice that (a) the natural
win32 APIs for this task include "isDirectory" in the result and (b)
readDirSync will return entries, rather than strings, if you pass
withFileTypes. It turns out this version, which allows us to dispense
with path math and stat calls is ~20X faster (enumerating a directory
with 600 children).