Skip to content

Conversation

@Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Mar 19, 2021

Closes #43092
Fixes #43012

dragomirtitian and others added 30 commits February 3, 2021 18:44
…ing except classes.

Changes objects literal checking to not bail on first private name found in object literal.
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Private methods inside class expressions should not error.

Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
Signed-off-by: Kubilay Kahveci <[email protected]>
mkubilayk and others added 13 commits March 17, 2021 12:26
…lds-methods-and-accessors' into es-private-methods-and-accessors
…lds-methods-and-accessors' into es-private-methods-and-accessors
… and modified the existing helpers for get and set fields to do the same job.
…-accessors-simplify-emit

Es private methods and accessors simplify emit
* Add types factory and parser

* Add some case

* Make class static block as a container

* Update cases

* Add visitor

* Add emitter and more compile target

* Check boundary of break and continue
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 19, 2021
@Kingwl Kingwl marked this pull request as draft March 19, 2021 07:45
@Kingwl Kingwl mentioned this pull request Mar 19, 2021
11 tasks
@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 19, 2021

Hi @dragomirtitian @mkubilayk !

Please take a look If you are Interested in this. Thanks!

@rbuckton rbuckton mentioned this pull request Mar 19, 2021
3 tasks
@orta
Copy link
Contributor

orta commented Mar 23, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 23, 2021

Heya @orta, I've started to run the tarball bundle task on this PR at 11a2934. You can monitor the build here.

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 23, 2021

Hoops. Seems something broken.

@orta
Copy link
Contributor

orta commented Mar 23, 2021

Interesting, you just updated the baselines which seems to be what the failing error message is about

@Kingwl Kingwl closed this Mar 25, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal class static block

6 participants