Update the file watching intervals and chunk size #6100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Pinging @vladima |
src/compiler/sys.ts
Outdated
Contributor
There was a problem hiding this comment.
add parameter names via /*...*/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the current polling file watching can result in long wait time for large watched file set. For example, for >120 watched files it takes ~10s to get the changes.
The new parameters would wait 1.5s each time, and process at most 100 files. It takes at most 3s to detect changes for a project of 200 files. As an average async stat takes about 30 microsecond, the overhead of each polling is 100*(30 microsecond) = 3 millisecond. However for a smaller project size, the overhead is determined by the numebr of files in the project.