Skip to content

Alternate fix for bpo-30822. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
musically-ut wants to merge 2 commits into from
Closed

Alternate fix for bpo-30822. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43a1d0d
Alternate fix for bpo-30822.
musically-ut Jul 3, 2017
fd41b2e
Remove the fragile dedeplication of test-cases.
musically-ut Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4855,10 +4855,12 @@ def __init__(self):
tests = []
if is_resource_enabled('tzdata'):
for name in ZoneInfo.zonenames():
Test = type('ZoneInfoTest[%s]' % name, (ZoneInfoTest,), {})
Test.zonename = name
for method in dir(Test):
for method in dir(ZoneInfoTest):
if method.startswith('test_'):
Test = type('ZoneInfoTest[%s]' % name,
(ZoneInfoTest,),
{})
Test.zonename = name
tests.append(Test(method))
super().__init__(tests)

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@
continue
if issubclass(cls, unittest.TestCase):
test_classes.append(cls)
all_test_classes.append(cls)
elif issubclass(cls, unittest.TestSuite):
suit = cls()
all_test_classes.append(suit)
test_classes.extend(type(test) for test in suit)
test_classes = sorted(set(test_classes), key=lambda cls: cls.__qualname__)
for cls in test_classes:
cls.__name__ += suffix
cls.__qualname__ += suffix
Expand All @@ -48,7 +49,6 @@ def tearDownClass(cls_):
sys.modules.update(cls_._save_sys_modules)
cls.setUpClass = setUpClass
cls.tearDownClass = tearDownClass
all_test_classes.extend(test_classes)

def test_main():
run_unittest(*all_test_classes)
Expand Down