src: remove duplicated code in GenerateSingleExecutableBlob()

Jungku Lee · RafaelGSS · commit 8d6948f8e280 · 2023-08-17T08:36:00.000-03:00
PR-URL: #49119 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/node_sea.cc b/src/node_sea.cc
@@ -486,13 +486,6 @@ ExitCode GenerateSingleExecutableBlob(
     }
   }
 
-  std::optional<std::string> optional_code_cache =
-      GenerateCodeCache(config.main_path, main_script);
-  if (!optional_code_cache.has_value()) {
-    FPrintF(stderr, "Cannot generate V8 code cache\n");
-    return ExitCode::kGenericUserError;
-  }
-
   std::optional<std::string_view> optional_sv_code_cache;
   std::string code_cache;
   if (static_cast<bool>(config.flags & SeaFlags::kUseCodeCache)) {

Original file line number	Diff line number	Diff line change
`@@ -486,13 +486,6 @@ ExitCode GenerateSingleExecutableBlob(`
`486`	`486`	`}`
`487`	`487`	`}`
`488`	`488`
`489`		`- std::optional<std::string> optional_code_cache =`
`490`		`- GenerateCodeCache(config.main_path, main_script);`
`491`		`- if (!optional_code_cache.has_value()) {`
`492`		`- FPrintF(stderr, "Cannot generate V8 code cache\n");`
`493`		`- return ExitCode::kGenericUserError;`
`494`		`- }`
`495`		`-`
`496`	`489`	`std::optional<std::string_view> optional_sv_code_cache;`
`497`	`490`	`std::string code_cache;`
`498`	`491`	`if (static_cast<bool>(config.flags & SeaFlags::kUseCodeCache)) {`