Revert "buffer: runtime deprecation of calling Buffer without new"

This reverts commit f2fe558
(#8169) as the original
justification for the runtime-deprecation does not appear
to justify the disruption to Node’s existing ecosystem.
Futhermore, the possibility of deprecating the Buffer constructor
entirely in v8.0 might lead to people having to change their code twice.

PR-URL: #9529
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

Author: addaleax

lib/buffer.js

@@ -72,17 +72,7 @@ function alignPool() {
  * much breakage at this time. It's not likely that the Buffer constructors
  * would ever actually be removed.
  **/
-var newBufferWarned = false;
 function Buffer(arg, encodingOrOffset, length) {
-  if (!new.target && !newBufferWarned) {
-    newBufferWarned = true;
-    process.emitWarning(
-      'Using Buffer without `new` will soon stop working. ' +
-      'Use `new Buffer()`, or preferably ' +
-      '`Buffer.from()`, `Buffer.allocUnsafe()` or `Buffer.alloc()` instead.',
-      'DeprecationWarning'
-    );
-  }
   // Common case.
   if (typeof arg === 'number') {
     if (typeof encodingOrOffset === 'string') {