fs: writeFile support AsyncIterable, Iterable & Stream as data argument

[yagipy]

Fixes: #37391

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[Linkgoron]

Currently this incorrectly handles fds that are given to it (path can be a FileHandle or a string). It tries to open them when it shouldn't and tries to close them in the end (If a FileHandle is passed into writeFile, its lifetime isn't managed by the method - i.e. it shouldn't be opened or closed)

IMO a cleaner solution would be to keep writeFile essentially the same as it is today (I think it would just need one change - changing if(!isArrayBufferView(...)) to if(!isIterable(...) && !isArrayBufferView(...)) , and moving the writing logic into writeFileHandle. This would also remove and simplify some code, because you won't have to manage the lifetime of the handle.

[yagipy]

@Linkgoron @aduh95
Thanks for reviewing it.

IMO a cleaner solution would be to keep writeFile essentially the same as it is today (I think it would just need one change - changing if(!isArrayBufferView(...)) to if(!isIterable(...) && !isArrayBufferView(...)) , and moving the writing logic into writeFileHandle. This would also remove and simplify some code, because you won't have to manage the lifetime of the handle.

I reimplemented it in the above direction.

[aduh95]

Can you please add an entry in the YAML changes list to document the change?

[aduh95]

LGTM, thanks a lot!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36341/