Skip to content

deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff #41564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luyahan wants to merge 0 commits into from
Closed

deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff #41564

luyahan wants to merge 0 commits into from

Conversation

@luyahan
Copy link
Contributor

@luyahan luyahan commented Jan 17, 2022 •
edited
Loading

Fix riscv64 segment fault
origin commit :

[riscv64][sparkplug] Fix sparkplug verify framesize failed

Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009
Auto-Submit: Yahan Lu <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#76277}

Refs: v8/v8@d8dc66f

[riscv64] Use s1 to save code_obj

The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj.

Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Ji Qiu <[email protected]>
Commit-Queue: Yahan Lu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#76294}

Refs: v8/v8@3cab84c

[riscv64] Link should greater and equal zero

Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673
Commit-Queue: Yahan Lu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#76784}

Refs: v8/v8@471f862

[riscv64] Add block before LoadAddress

fix node.js DCHECK failed
issue: https://github.com/riscv-collab/v8/issues/514

Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
Reviewed-by: ji qiu <[email protected]>
Commit-Queue: ji qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ff

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2022

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 17, 2022
@luyahan luyahan changed the title deps: v8 cherry-pick d8dc66f 3cab84c 471f862 deps: V8: cherry-pick d8dc66f 3cab84c 471f862 Jan 17, 2022
@XieJiSS
Copy link

XieJiSS commented Jan 17, 2022 •
edited
Loading

@luyahan Hi, I‘m trying to build nodejs v16.13.1 these days. By applying your patch 1 and 2 (d8dc66f & 3cab84c, ref: riscv-collab/v8#516 (comment)), and if configured with --without-inspector, nodejs v16.13.1 can compile & pass all tests on SiFive Unmatched boards. Without specifying --without-inspector, test/parallel/test-v8-coverage.js would crash (signal 11). Is this what patch 3 is for?

@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

@luyahan Hi, I‘m trying to build nodejs v16.13.1 these days. By applying your patch 1 and 2 (d8dc66f & 3cab84c, ref: riscv-collab/v8#516 (comment)), and if configured with --without-inspector, nodejs v16.13.1 can compile & pass all tests on SiFive Unmatched boards. Without specifying --without-inspector, test/parallel/test-v8-coverage.js would crash (signal 11). Is this what patch 3 is for?

thanks your info ，i will to look it.

@luyahan luyahan changed the title deps: V8: cherry-pick d8dc66f 3cab84c 471f862 deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff Jan 17, 2022
gengjiawen
gengjiawen requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luyahan You may need use https://github.com/nodejs/node-core-utils/blob/main/docs/git-node.md#git-node-v8-backport-sha

Generally you need bump common.gypi and we generally not squash cherrypick commit

@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022 •
edited
Loading

@luyahan You may need use https://github.com/nodejs/node-core-utils/blob/main/docs/git-node.md#git-node-v8-backport-sha

Generally you need bump common.gypi and we generally not squash cherrypick commit

@gengjiawen I run git node backport

luyahan@p9-plct:~/source/node $ git node v8 backport 77599ff
✔ Update local V8 clone
❯ V8 commit backport
  ✔ Get current V8 version
  ✔ Generate patches
  ❯ Apply and commit patches to deps/v8
    ❯ Commit 77599ffe0a74
      ⠦ Apply patch
      ◼ Increment embedder version number
      ◼ Commit patch

? Resolve merge conflicts and enter 'RESOLVED' ‣

▸ Invalid input

What can i do to fix conflict? I can't find any conflicts in edit.

@gengjiawen
Copy link
Member

gengjiawen commented Jan 17, 2022

@luyahan You may need use nodejs/node-core-utils@main/docs/git-node.md#git-node-v8-backport-sha
Generally you need bump common.gypi and we generally not squash cherrypick commit

@gengjiawen I run git node backport

luyahan@p9-plct:~/source/node $ git node v8 backport 77599ff
✔ Update local V8 clone
❯ V8 commit backport
  ✔ Get current V8 version
  ✔ Generate patches
  ❯ Apply and commit patches to deps/v8
    ❯ Commit 77599ffe0a74
      ⠦ Apply patch
      ◼ Increment embedder version number
      ◼ Commit patch

? Resolve merge conflicts and enter 'RESOLVED' ‣

▸ Invalid input

What can i do to fix conflict? I can't find any conflicts in edit.

Not sure (is you local branch reset to nodejs:v16.x-staging ). You can create an issue here https://github.com/nodejs/node-core-utils/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

@targos
Copy link
Member

targos commented Jan 17, 2022

I think it's okay to squash all fixes here since they all apply to the same platform.

@luyahan luyahan closed this Jan 17, 2022
@gengjiawen
Copy link
Member

gengjiawen commented Jan 17, 2022

I think it's okay to squash all fixes here since they all apply to the same platform.

I am okay with this. So only bump common.gypi lgtm

@targos
Copy link
Member

targos commented Jan 17, 2022

@luyahan did you target v16.x-staging because the fixes are already in v17.x ?

@luyahan luyahan mentioned this pull request Jan 17, 2022
Closed
@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

@luyahan Hi, I‘m trying to build nodejs v16.13.1 these days. By applying your patch 1 and 2 (d8dc66f & 3cab84c, ref: riscv-collab/v8#516 (comment)), and if configured with --without-inspector, nodejs v16.13.1 can compile & pass all tests on SiFive Unmatched boards. Without specifying --without-inspector, test/parallel/test-v8-coverage.js would crash (signal 11). Is this what patch 3 is for?

This pacth can fix Refs: v8/v8@77599ff

@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

@luyahan did you target v16.x-staging because the fixes are already in v17.x ?

Yes, these patch had been add into v17.x.

@luyahan
Copy link
Contributor Author

luyahan commented Jan 17, 2022

I reopen this pr in #41566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen requested changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luyahan @nodejs-github-bot @XieJiSS @gengjiawen @targos