Skip to content

url: do not append slashes when unicode is enabled if empty hostname #49087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Xstoudi wants to merge 2 commits into from
Closed

url: do not append slashes when unicode is enabled if empty hostname #49087

Xstoudi wants to merge 2 commits into from

Conversation

@Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Aug 9, 2023

Fixes: #48759

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 9, 2023

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 9, 2023
@anonrig
Copy link
Member

anonrig commented Aug 10, 2023

@Xstoudi Can you rebase and force-push?

@anonrig anonrig mentioned this pull request Aug 28, 2023
Merged
@anonrig anonrig closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WHATWG URL API format() function inserts '//' wrongly when 'unicode' is set

4 participants

@Xstoudi @nodejs-github-bot @anonrig @lpinca