Skip to content

[v20.x backport] src: move package_json_reader cache to c++ #53502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anonrig wants to merge 3 commits into from
Closed

[v20.x backport] src: move package_json_reader cache to c++ #53502

anonrig wants to merge 3 commits into from

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jun 18, 2024 •
edited
Loading

Backports #50322 to v20

cc @nodejs/releasers @joyeecheung @GeoffreyBooth

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2024

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/loaders
  • @nodejs/security-wg
  • @nodejs/startup
  • @nodejs/tsc
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jun 18, 2024
@anonrig anonrig changed the title Backport 50322 to 20 [v20.x backport] src: move package_json_reader cache to c++ Jun 18, 2024
@anonrig anonrig force-pushed the backport-50322-to-20 branch from 8f0ec43 to ff40d15 Compare June 18, 2024 16:28
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024
@richardlau
Copy link
Member

richardlau commented Jun 18, 2024

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

@marco-ippolito marco-ippolito mentioned this pull request Jun 18, 2024
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59869/

@anonrig
Copy link
Member Author

anonrig commented Jun 18, 2024

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

I used git node backport 50322 --to=20 but unfortunately it didn't add at all. I'll update the PR once the existing tests pass (to avoid re-running again)

@joyeecheung
Copy link
Member

joyeecheung commented Jun 18, 2024

I think @richardlau meant that you only need to keep the commit message as-is and additional URLs will be added when they land on v20.x-staging.

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 26, 2024

can you please rebase? there are some undici commits we removed from staging

@anonrig anonrig force-pushed the backport-50322-to-20 branch from ff40d15 to b447a68 Compare June 27, 2024 15:20
anonrig added 3 commits June 27, 2024 11:22
@anonrig
deps: add simdjson
7f4d716 
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@anonrig
src: move package resolver to c++
19640ce 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

# Conflicts:
#	lib/internal/modules/package_json_reader.js
#	src/node_file.cc
#	test/parallel/test-module-binding.js
@anonrig
module: merge config with package_json_reader
af801aa 
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@anonrig anonrig force-pushed the backport-50322-to-20 branch from b447a68 to af801aa Compare June 27, 2024 17:36
@anonrig anonrig requested a review from marco-ippolito July 15, 2024 15:25
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60336/

@marco-ippolito
Copy link
Member

marco-ippolito commented Jul 30, 2024

@anonrig there is some issue with the backport, does not compile

@targos targos force-pushed the v20.x-staging branch 2 times, most recently from 47be236 to 9e1c229 Compare October 2, 2024 14:06
@anonrig anonrig closed this Dec 11, 2024
@joyeecheung
Copy link
Member

joyeecheung commented Jan 13, 2025

This is blocking the require(esm) backport. I will try to backport it again.

This was referenced Jan 13, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito Awaiting requested review from marco-ippolito

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig @nodejs-github-bot @richardlau @joyeecheung @marco-ippolito