Remove personalisation from write on readonly db DBA error message

Author: Girgias

ext/dba/dba.c

@@ -139,8 +139,8 @@ static zend_string* php_dba_make_key(HashTable *key)
 
 /* check whether the user has write access */
 #define DBA_WRITE_CHECK(info) \
-	if((info)->mode != DBA_WRITER && (info)->mode != DBA_TRUNC && (info)->mode != DBA_CREAT) { \
-		php_error_docref(NULL, E_WARNING, "You cannot perform a modification to a database without proper access"); \
+	if ((info)->mode != DBA_WRITER && (info)->mode != DBA_TRUNC && (info)->mode != DBA_CREAT) { \
+		php_error_docref(NULL, E_WARNING, "Cannot perform a modification on a readonly database"); \
 		RETURN_FALSE; \
 	}
 

ext/dba/tests/dba_cdb_001.phpt

@@ -82,7 +82,7 @@ Warning: dba_open(): Driver initialization failed for handler: cdb: Update opera
 Failed to open DB
 Test 2
 
-Warning: dba_insert(): You cannot perform a modification to a database without proper access in %sdba_cdb_001.php on line %d
+Warning: dba_insert(): Cannot perform a modification on a readonly database in %sdba_cdb_001.php on line %d
 Test 3
 
 Warning: dba_open(): Driver initialization failed for handler: cdb: Update operations are not supported in %sdba_cdb_001.php on line %d

ext/dba/tests/dba_lmdb_readonly.phpt

@@ -0,0 +1,37 @@
+--TEST--
+DBA LMDB handler readonly test
+--EXTENSIONS--
+dba
+--SKIPIF--
+<?php
+    $handler = 'lmdb';
+    require_once __DIR__ .'/skipif.inc';
+?>
+--FILE--
+<?php
+$handler = 'lmdb';
+$db_filename = __DIR__ . "/lmdb-readonly.dbm";
+
+// Create DB
+$db_file = dba_open($db_filename, "c", $handler);
+assert($db_file !== false);
+// Close handler
+dba_close($db_file);
+
+// Open in read only mode
+$db_file = dba_open($db_filename, "r", $handler);
+assert($db_file !== false);
+
+// Try inserting
+dba_insert("key1", "This is a test insert", $db_file);
+dba_close($db_file);
+?>
+--CLEAN--
+<?php
+$db_filename = __DIR__ . "/lmdb-readonly.dbm";
+@unlink($db_filename);
+@unlink($db_filename.'.lck');
+@unlink($db_filename.'-lock');
+?>
+--EXPECTF--
+Warning: dba_insert(): Cannot perform a modification on a readonly database in %s on line %d