ext/opcache/zend_shared_alloc: change "locked" check to assertion

Calling zend_shared_alloc() without holding the lock is always a bug,
not a fatal runtime error.

Author: MaxKellermann

ext/opcache/zend_shared_alloc.c

@@ -336,18 +336,15 @@ static size_t zend_shared_alloc_get_largest_free_block(void)
 
 void *zend_shared_alloc(size_t size)
 {
+	ZEND_ASSERT(ZCG(locked));
+
 	int i;
 	unsigned int block_size = ZEND_ALIGNED_SIZE(size);
 
 	if (UNEXPECTED(block_size < size)) {
 		zend_accel_error_noreturn(ACCEL_LOG_ERROR, "Possible integer overflow in shared memory allocation (%zu + %zu)", size, PLATFORM_ALIGNMENT);
 	}
 
-#if 1
-	if (!ZCG(locked)) {
-		zend_accel_error_noreturn(ACCEL_LOG_ERROR, "Shared memory lock not obtained");
-	}
-#endif
 	if (block_size > ZSMMG(shared_free)) { /* No hope to find a big-enough block */
 		SHARED_ALLOC_FAILED();
 		return NULL;