Implement DOMElement::getAttributeNames()

ndossche · ndossche · commit 10d7e8dc3ad2 · 2023-07-13T16:18:10.000+02:00
ref: https://dom.spec.whatwg.org/#dom-element-getattributenames
diff --git a/NEWS b/NEWS
@@ -17,6 +17,7 @@ PHP                                                                        NEWS
 
 - DOM:
   . Added DOMNode::contains() and DOMNameSpaceNode::contains(). (nielsdos)
+  . Added DOMElement::getAttributeNames(). (nielsdos)
 
 - Intl:
   . Fix memory leak in MessageFormatter::format() on failure. (Girgias)
diff --git a/UPGRADING b/UPGRADING
@@ -242,6 +242,7 @@ PHP 8.3 UPGRADE NOTES
 
 - DOM:
   . Added DOMNode::contains() and DOMNameSpaceNode::contains().
+  . Added DOMElement::getAttributeNames().
 
 - JSON:
   . Added json_validate(), which returns whether the json is valid for
diff --git a/ext/dom/element.c b/ext/dom/element.c
@@ -242,6 +242,39 @@ PHP_METHOD(DOMElement, getAttribute)
 }
 /* }}} end dom_element_get_attribute */
 
+/* {{{ URL: https://dom.spec.whatwg.org/#dom-element-getattributenames
+Since:
+*/
+PHP_METHOD(DOMElement, getAttributeNames)
+{
+	zval *id;
+	xmlNode *nodep;
+	dom_object *unused_intern;
+	zval tmp;
+
+	if (zend_parse_parameters_none() == FAILURE) {
+		RETURN_THROWS();
+	}
+
+	DOM_GET_THIS_OBJ(nodep, id, xmlNodePtr, unused_intern);
+
+	array_init(return_value);
+	HashTable *ht = Z_ARRVAL_P(return_value);
+	zend_hash_real_init_packed(ht);
+
+	for (xmlNsPtr nsptr = nodep->nsDef; nsptr; nsptr = nsptr->next) {
+		const char *prefix = (const char *) nsptr->prefix;
+		ZVAL_STR(&tmp, dom_node_concatenated_name_helper(strlen(prefix), prefix, strlen("xmlns"), (const char *) "xmlns"));
+		zend_hash_next_index_insert(ht, &tmp);
+	}
+
+	for (xmlAttrPtr attr = nodep->properties; attr; attr = attr->next) {
+		ZVAL_STR(&tmp, dom_node_get_node_name_attribute_or_element((const xmlNode *) attr));
+		zend_hash_next_index_insert(ht, &tmp);
+	}
+}
+/* }}} end DOMElement::getAttributeNames() */
+
 /* {{{ URL: http://www.w3.org/TR/2003/WD-DOM-Level-3-Core-20030226/DOM3-Core.html#core-ID-F68F082
 Since:
 */
diff --git a/ext/dom/php_dom.stub.php b/ext/dom/php_dom.stub.php
@@ -563,6 +563,8 @@ public function __construct(string $qualifiedName, ?string $value = null, string
     /** @tentative-return-type */
     public function getAttribute(string $qualifiedName): string {}
 
+    public function getAttributeNames(): array {}
+
     /** @tentative-return-type */
     public function getAttributeNS(?string $namespace, string $localName): string {}
 
diff --git a/ext/dom/php_dom_arginfo.h b/ext/dom/php_dom_arginfo.h
diff --git a/ext/dom/tests/DOMElement_getAttributeNames.phpt b/ext/dom/tests/DOMElement_getAttributeNames.phpt
@@ -0,0 +1,38 @@
+--TEST--
+DOMElement::getAttributeNames()
+--EXTENSIONS--
+dom
+--FILE--
+<?php
+
+function test($str) {
+    $dom = new DOMDocument();
+    $dom->loadXML($str);
+    var_dump($dom->documentElement->getAttributeNames());
+    foreach ($dom->documentElement->getAttributeNames() as $name) {
+        assert($dom->documentElement->getAttributeNode($name)->nodeName === $name);
+    }
+}
+
+test('<html xmlns:some="some:ns" some:test="a" test2="b"/>');
+test('<html test="b" test3="c"/>');
+test('<html/>');
+
+?>
+--EXPECT--
+array(3) {
+  [0]=>
+  string(10) "xmlns:some"
+  [1]=>
+  string(9) "some:test"
+  [2]=>
+  string(5) "test2"
+}
+array(2) {
+  [0]=>
+  string(4) "test"
+  [1]=>
+  string(5) "test3"
+}
+array(0) {
+}
