ext/opcache/zend_shared_alloc: rename _register_xlat_entry() params

The name "new" happens to be a C++ keyword, which was the my reason to
rethink those names.

The "xlat_table" is not only used to translate pointers for persisting
scripts to shared memory, but is also used to annoate pointers
(e.g. by the JIT to associate an op_array with its jit_extension).

The names "old" and "new" aren't good for that; often, there's nothing
"old" or "new" about them.  It's actually a generic lookup table, and
"old" shall be named "key" (which it is called internally already),
and "new" is renamed to simply "value".

Author: MaxKellermann

ext/opcache/zend_shared_alloc.c

@@ -541,18 +541,18 @@ void zend_shared_alloc_restore_xlat_table(uint32_t checkpoint)
 	zend_hash_discard(&ZCG(xlat_table), checkpoint);
 }
 
-void zend_shared_alloc_register_xlat_entry(const void *old, const void *new)
+void zend_shared_alloc_register_xlat_entry(const void *key_pointer, const void *value)
 {
-	zend_ulong key = (zend_ulong)old;
+	zend_ulong key = (zend_ulong)key_pointer;
 
 	key = zend_rotr3(key);
-	zend_hash_index_add_new_ptr(&ZCG(xlat_table), key, (void*)new);
+	zend_hash_index_add_new_ptr(&ZCG(xlat_table), key, (void*)value);
 }
 
-void *zend_shared_alloc_get_xlat_entry(const void *old)
+void *zend_shared_alloc_get_xlat_entry(const void *key_pointer)
 {
 	void *retval;
-	zend_ulong key = (zend_ulong)old;
+	zend_ulong key = (zend_ulong)key_pointer;
 
 	key = zend_rotr3(key);
 	if ((retval = zend_hash_index_find_ptr(&ZCG(xlat_table), key)) == NULL) {

ext/opcache/zend_shared_alloc.h

@@ -185,8 +185,8 @@ void zend_shared_alloc_destroy_xlat_table(void);
 void zend_shared_alloc_clear_xlat_table(void);
 uint32_t zend_shared_alloc_checkpoint_xlat_table(void);
 void zend_shared_alloc_restore_xlat_table(uint32_t checkpoint);
-void zend_shared_alloc_register_xlat_entry(const void *old, const void *new);
-void *zend_shared_alloc_get_xlat_entry(const void *old);
+void zend_shared_alloc_register_xlat_entry(const void *key, const void *value);
+void *zend_shared_alloc_get_xlat_entry(const void *key);
 
 size_t zend_shared_alloc_get_free_memory(void);
 void zend_shared_alloc_save_state(void);