RFC: Deprecate remains of string evaluated code assertions (#11671)

Link: https://wiki.php.net/rfc/assert-string-eval-cleanup

Author: Girgias

UPGRADING

@@ -126,6 +126,12 @@ PHP 8.3 UPGRADE NOTES
   . The MT_RAND_PHP Mt19937 variant is deprecated.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_3#mt_rand_php
 
+- Standard:
+  . The assert_option() function is now deprecated.
+  . The ASSERT_ACTIVE, ASSERT_BAIL,ASSERT_CALLBACK, ASSERT_EXCEPTION, and
+    ASSERT_WARNING constants have been deprecated.
+    RFC: https://wiki.php.net/rfc/assert-string-eval-cleanup
+
 - SQLite3
   . Using exceptions is now preferred, warnings will be removed in the future.
     Calling SQLite3::enableExceptions(false) will trigger a depreciation warning
@@ -364,6 +370,18 @@ PHP 8.3 UPGRADE NOTES
 11. Changes to INI File Handling
 ========================================
 
+- assert.*
+  . The assert.* INI settings have been deprecated.
+    This comprises the following INI settings:
+     - assert.active
+     - assert.bail
+     - assert.callback
+     - assert.exception
+     - assert.warning
+    If the value of the setting is equal to the default value, no deprecation
+    notice is emitted.
+    The zend.assertions INI setting should be used instead.
+
 - zend.max_allowed_stack_size
   . New INI directive to set the maximum allowed stack size. Possible
     values are `0` (detect the process or thread maximum stack size), `-1`

Zend/tests/arrow_functions/007.phpt

@@ -2,16 +2,24 @@
 Pretty printing for arrow functions
 --INI--
 zend.assertions=1
-assert.exception=0
 --FILE--
 <?php
 
 // TODO We're missing parentheses for the direct call
-assert((fn() => false)());
-assert((fn&(int... $args): ?bool => $args[0])(false));
 
-?>
---EXPECTF--
-Warning: assert(): assert(fn() => false()) failed in %s on line %d
+try {
+    assert((fn() => false)());
+} catch (AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
+
+try {
+    assert((fn&(int... $args): ?bool => $args[0])(false));
+} catch (AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 
-Warning: assert(): assert(fn&(int ...$args): ?bool => $args[0](false)) failed in %s on line %d
+?>
+--EXPECT--
+assert(): assert(fn() => false()) failed
+assert(): assert(fn&(int ...$args): ?bool => $args[0](false)) failed

Zend/tests/assert/bug70528.phpt

@@ -2,22 +2,30 @@
 Bug #70528 (assert() with instanceof adds apostrophes around class name)
 --INI--
 zend.assertions=1
-assert.exception=0
-assert.warning=1
 --FILE--
 <?php
 
 namespace Foo;
 class Bar {}
 
 $bar = "Bar";
-assert(new \stdClass instanceof $bar);
-assert(new \stdClass instanceof Bar);
-assert(new \stdClass instanceof \Foo\Bar);
+try {
+    assert(new \stdClass instanceof $bar);
+} catch (\AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
+try {
+    assert(new \stdClass instanceof Bar);
+} catch (\AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
+try {
+    assert(new \stdClass instanceof \Foo\Bar);
+} catch (\AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 ?>
---EXPECTF--
-Warning: assert(): assert(new \stdClass() instanceof $bar) failed in %sbug70528.php on line %d
-
-Warning: assert(): assert(new \stdClass() instanceof Bar) failed in %sbug70528.php on line %d
-
-Warning: assert(): assert(new \stdClass() instanceof \Foo\Bar) failed in %sbug70528.php on line %d
+--EXPECT--
+assert(): assert(new \stdClass() instanceof $bar) failed
+assert(): assert(new \stdClass() instanceof Bar) failed
+assert(): assert(new \stdClass() instanceof \Foo\Bar) failed

Zend/tests/assert/expect_015.phpt

@@ -2,9 +2,9 @@
 AST pretty-peinter
 --INI--
 zend.assertions=1
-assert.exception=0
 --FILE--
 <?php
+try {
 assert(0 && ($a = function () {
     global $a, $$b;
     static $c, $d = 0;
@@ -19,7 +19,11 @@ assert(0 && ($a = function () {
     yield 1 => 2;
     yield from $x;
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
+try {
 assert(0 && ($a = function &(array &$a, ?X $b = null) use ($c,&$d) : ?X {
     abstract class A extends B implements C, D {
         const X = 12;
@@ -64,7 +68,11 @@ assert(0 && ($a = function &(array &$a, ?X $b = null) use ($c,&$d) : ?X {
         }
     }
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
+try {
 assert(0 && ($a = function &(array &$a, X $b = null, int|float $c) use ($c,&$d) : X {
     final class A {
         final protected function f2() {
@@ -96,7 +104,11 @@ L0:
         }
     }
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
+try {
 assert(0 && ($a = function &(?array &$a, X $b = null) use ($c,&$d) : X {
     class A {
         use T1, T2 {
@@ -108,7 +120,11 @@ assert(0 && ($a = function &(?array &$a, X $b = null) use ($c,&$d) : X {
         use T3;
     }
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
+try {
 assert(0 && ($a = function &(array &...$a) {
     declare(A=1,B=2);
     try {
@@ -121,7 +137,11 @@ assert(0 && ($a = function &(array &...$a) {
         echo 3;
     }
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
+try {
 assert(0 && ($a = function (): ?static {
     declare(C=1) { echo 1; }
     $x = '\'"`$a';
@@ -145,10 +165,13 @@ assert(0 && ($a = function (): ?static {
     }
     if ($a); else;
 }));
+} catch (AssertionError $e) {
+    echo $e->getMessage(), PHP_EOL;
+}
 
 ?>
---EXPECTF--
-Warning: assert(): assert(0 && ($a = function () {
+--EXPECT--
+assert(0 && ($a = function () {
     global $a;
     global $$b;
     static $c;
@@ -163,9 +186,8 @@ Warning: assert(): assert(0 && ($a = function () {
     $y = clone $x;
     yield 1 => 2;
     yield from $x;
-})) failed in %s on line %d
-
-Warning: assert(): assert(0 && ($a = function &(array &$a, ?X $b = null) use($c, &$d): ?X {
+}))
+assert(0 && ($a = function &(array &$a, ?X $b = null) use($c, &$d): ?X {
     abstract class A extends B implements C, D {
         public const X = 12;
         public const Y = self::X, Z = 'aaa';
@@ -208,9 +230,8 @@ Warning: assert(): assert(0 && ($a = function &(array &$a, ?X $b = null) use($c,
 
     }
 
-})) failed in %s on line %d
-
-Warning: assert(): assert(0 && ($a = function &(array &$a, X $b = null, int|float $c) use($c, &$d): X {
+}))
+assert(0 && ($a = function &(array &$a, X $b = null, int|float $c) use($c, &$d): X {
     final class A {
         protected final function f2() {
             if (!$x) {
@@ -248,9 +269,8 @@ Warning: assert(): assert(0 && ($a = function &(array &$a, X $b = null, int|floa
 
     }
 
-})) failed in %s on line %d
-
-Warning: assert(): assert(0 && ($a = function &(?array &$a, X $b = null) use($c, &$d): X {
+}))
+assert(0 && ($a = function &(?array &$a, X $b = null) use($c, &$d): X {
     class A {
         use T1, T2 {
             T1::foo insteadof foo;
@@ -261,9 +281,8 @@ Warning: assert(): assert(0 && ($a = function &(?array &$a, X $b = null) use($c,
         use T3;
     }
 
-})) failed in %s on line %d
-
-Warning: assert(): assert(0 && ($a = function &(array &...$a) {
+}))
+assert(0 && ($a = function &(array &...$a) {
     declare(A = 1, B = 2);
     try {
         $i++;
@@ -274,9 +293,8 @@ Warning: assert(): assert(0 && ($a = function &(array &...$a) {
     } finally {
         echo 3;
     }
-})) failed in %s on line %d
-
-Warning: assert(): assert(0 && ($a = function (): ?static {
+}))
+assert(0 && ($a = function (): ?static {
     declare(C = 1) {
         echo 1;
     }
@@ -302,4 +320,4 @@ Warning: assert(): assert(0 && ($a = function (): ?static {
     if ($a) {
     } else {
     }
-})) failed in %s on line %d
+}))

Zend/tests/assert/expect_016.phpt

@@ -2,23 +2,24 @@
 test enable/disable assertions at runtime (assertions not completely disabled)
 --INI--
 zend.assertions=0
-assert.exception=0
 --FILE--
 <?php
 ini_set("zend.assertions", 0);
 var_dump(assert(false));
 var_dump(assert(true));
 ini_set("zend.assertions", 1);
-var_dump(assert(false));
+try {
+    var_dump(assert(false));
+} catch (AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 var_dump(assert(true));
 ini_set("zend.assertions", -1);
 ?>
 --EXPECTF--
 bool(true)
 bool(true)
-
-Warning: assert(): assert(false) failed in %sexpect_016.php on line 6
-bool(false)
+assert(): assert(false) failed
 bool(true)
 
-Warning: zend.assertions may be completely enabled or disabled only in php.ini in %sexpect_016.php on line 8
+Warning: zend.assertions may be completely enabled or disabled only in php.ini in %s on line %d

Zend/tests/assert/expect_017.phpt

@@ -2,18 +2,16 @@
 test enable/disable assertions at runtime (assertions completely disabled)
 --INI--
 zend.assertions=-1
-assert.exception=0
 --FILE--
 <?php
+ini_set("zend.assertions", 0);
 var_dump(assert(false));
 var_dump(assert(true));
-ini_set("zend.assertions", 0);
 ini_set("zend.assertions", 1);
 ?>
 --EXPECTF--
+Warning: zend.assertions may be completely enabled or disabled only in php.ini in %sexpect_017.php on line 2
 bool(true)
 bool(true)
 
-Warning: zend.assertions may be completely enabled or disabled only in php.ini in %sexpect_017.php on line 4
-
 Warning: zend.assertions may be completely enabled or disabled only in php.ini in %sexpect_017.php on line 5

Zend/tests/assert/expect_018.phpt

@@ -2,7 +2,6 @@
 test assertions in namespace
 --INI--
 zend.assertions=1
-assert.exception=0
 --FILE--
 <?php
 namespace Foo;
@@ -13,21 +12,25 @@ var_dump(\assert(true));
 var_dump(assert(false));
 var_dump(assert(true));
 ini_set("zend.assertions", 1);
-var_dump(\assert(false));
+try {
+    var_dump(\assert(false));
+} catch (\AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 var_dump(\assert(true));
-var_dump(assert(false));
+try {
+    var_dump(assert(false));
+} catch (\AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 var_dump(assert(true));
 ?>
---EXPECTF--
+--EXPECT--
 bool(true)
 bool(true)
 bool(true)
 bool(true)
-
-Warning: assert(): assert(false) failed in %sexpect_018.php on line 10
-bool(false)
+assert(): assert(false) failed
 bool(true)
-
-Warning: assert(): assert(false) failed in %sexpect_018.php on line 12
-bool(false)
+assert(): assert(false) failed
 bool(true)

Zend/tests/assert/expect_019.phpt

@@ -2,7 +2,6 @@
 test assertions in namespace (assertions completely disabled)
 --INI--
 zend.assertions=-1
-assert.exception=0
 --FILE--
 <?php
 namespace Foo;

Zend/tests/assert/expect_020.phpt

@@ -2,16 +2,19 @@
 AST pretty-printer
 --INI--
 zend.assertions=1
-assert.exception=0
 --FILE--
 <?php
+try {
 assert(0 && ($a = function () {
     $var = 'test';
     $str = "$var, $var[1], {$var}[], {$var[1]}[], ${var}[], ${var[1]}[]";
 }));
+} catch (AssertionError $e) {
+    echo 'assert(): ', $e->getMessage(), ' failed', PHP_EOL;
+}
 ?>
---EXPECTF--
-Warning: assert(): assert(0 && ($a = function () {
+--EXPECT--
+assert(): assert(0 && ($a = function () {
     $var = 'test';
     $str = "$var, {$var[1]}, {$var}[], {$var[1]}[], {$var}[], {$var[1]}[]";
-})) failed in %sexpect_020.php on line %d
+})) failed