Register parameter attributes via stub in ext/zend_test (#10183)

Author: TimWolla

ext/zend_test/test.c

@@ -747,61 +747,12 @@ PHP_MINIT_FUNCTION(zend_test)
 	zend_test_parameter_attribute = register_class_ZendTestParameterAttribute();
 	zend_mark_internal_attribute(zend_test_parameter_attribute);
 
-	{
-		zend_attribute *attr;
-
-		attr = zend_add_parameter_attribute(
-			zend_hash_str_find_ptr(CG(function_table), "zend_test_parameter_with_attribute", sizeof("zend_test_parameter_with_attribute") - 1),
-			0,
-			zend_test_parameter_attribute->name,
-			1
-		);
-
-		ZVAL_PSTRING(&attr->args[0].value, "value1");
-	}
-
 	zend_test_property_attribute = register_class_ZendTestPropertyAttribute();
 	zend_mark_internal_attribute(zend_test_property_attribute);
 
 	zend_test_class_with_method_with_parameter_attribute = register_class_ZendTestClassWithMethodWithParameterAttribute();
-
-	{
-		zend_attribute *attr;
-
-		attr = zend_add_parameter_attribute(
-			zend_hash_str_find_ptr(&zend_test_class_with_method_with_parameter_attribute->function_table, "no_override", sizeof("no_override") - 1),
-			0,
-			zend_test_parameter_attribute->name,
-			1
-		);
-
-		ZVAL_PSTRING(&attr->args[0].value, "value2");
-
-		attr = zend_add_parameter_attribute(
-			zend_hash_str_find_ptr(&zend_test_class_with_method_with_parameter_attribute->function_table, "override", sizeof("override") - 1),
-			0,
-			zend_test_parameter_attribute->name,
-			1
-		);
-
-		ZVAL_PSTRING(&attr->args[0].value, "value3");
-	}
-
 	zend_test_child_class_with_method_with_parameter_attribute = register_class_ZendTestChildClassWithMethodWithParameterAttribute(zend_test_class_with_method_with_parameter_attribute);
 
-	{
-		zend_attribute *attr;
-
-		attr = zend_add_parameter_attribute(
-			zend_hash_str_find_ptr(&zend_test_child_class_with_method_with_parameter_attribute->function_table, "override", sizeof("override") - 1),
-			0,
-			zend_test_parameter_attribute->name,
-			1
-		);
-
-		ZVAL_PSTRING(&attr->args[0].value, "value4");
-	}
-
 	zend_test_forbid_dynamic_call = register_class_ZendTestForbidDynamicCall();
 
 	zend_test_ns_foo_class = register_class_ZendTestNS_Foo();

ext/zend_test/test.stub.php

@@ -74,12 +74,21 @@ public function __construct(string $parameter) {}
     }
 
     class ZendTestClassWithMethodWithParameterAttribute {
-        final public function no_override(string $parameter): int {}
-        public function override(string $parameter): int {}
+        final public function no_override(
+            #[ZendTestParameterAttribute("value2")]
+            string $parameter
+        ): int {}
+        public function override(
+            #[ZendTestParameterAttribute("value3")]
+            string $parameter
+        ): int {}
     }
 
     class ZendTestChildClassWithMethodWithParameterAttribute extends ZendTestClassWithMethodWithParameterAttribute {
-        public function override(string $parameter): int {}
+        public function override(
+            #[ZendTestParameterAttribute("value4")]
+            string $parameter
+        ): int {}
     }
 
     final class ZendTestForbidDynamicCall {
@@ -151,7 +160,10 @@ function zend_weakmap_dump(): array {}
 
     function zend_get_unit_enum(): ZendTestUnitEnum {}
 
-    function zend_test_parameter_with_attribute(string $parameter): int {}
+    function zend_test_parameter_with_attribute(
+        #[ZendTestParameterAttribute("value1")]
+        string $parameter
+    ): int {}
 
     function zend_get_current_func_name(): string {}