Fix memory leak in LMDB driver

Girgias · Girgias · commit 5b83b3a933d1 · 2022-07-21T14:05:48.000+01:00
diff --git a/NEWS b/NEWS
@@ -2,6 +2,9 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 2022, PHP 8.0.23
 
+- DBA:
+  . Fixed LMDB driver memory leak on DB creation failure (Girgias)
+
 - Standard:
   . Fixed bug GH-9017 (php_stream_sock_open_from_socket could return NULL).
     (Heiko Weber)
diff --git a/ext/dba/dba_lmdb.c b/ext/dba/dba_lmdb.c
@@ -72,6 +72,7 @@ DBA_OPEN_FUNC(lmdb)
 
 	rc = mdb_env_open(env, info->path, flags, mode);
 	if (rc) {
+		mdb_env_close(env);
 		*error = mdb_strerror(rc);
 		return FAILURE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ DBA_OPEN_FUNC(lmdb)`
`72`	`72`
`73`	`73`	`rc = mdb_env_open(env, info->path, flags, mode);`
`74`	`74`	`if (rc) {`
	`75`	`+ mdb_env_close(env);`
`75`	`76`	`*error = mdb_strerror(rc);`
`76`	`77`	`return FAILURE;`
`77`	`78`	`}`