Zend/zend_ini_scanner: zend_ini_scanner_get_filename() returns const string

Author: MaxKellermann

Zend/zend_ini_parser.y

@@ -187,9 +187,8 @@ static ZEND_COLD void ini_error(const char *msg)
 {
 	char *error_buf;
 	int error_buf_len;
-	char *currently_parsed_filename;
 
-	currently_parsed_filename = zend_ini_scanner_get_filename();
+	const char *const currently_parsed_filename = zend_ini_scanner_get_filename();
 	if (currently_parsed_filename) {
 		error_buf_len = 128 + (int)strlen(msg) + (int)strlen(currently_parsed_filename); /* should be more than enough */
 		error_buf = (char *) emalloc(error_buf_len);

Zend/zend_ini_scanner.h

@@ -27,7 +27,7 @@
 
 BEGIN_EXTERN_C()
 ZEND_COLD int zend_ini_scanner_get_lineno(void);
-ZEND_COLD char *zend_ini_scanner_get_filename(void);
+ZEND_COLD const char *zend_ini_scanner_get_filename(void);
 zend_result zend_ini_open_file_for_scanning(zend_file_handle *fh, int scanner_mode);
 zend_result zend_ini_prepare_string_for_scanning(char *str, int scanner_mode);
 int ini_lex(zval *ini_lval);

Zend/zend_ini_scanner.l

@@ -261,7 +261,7 @@ ZEND_COLD int zend_ini_scanner_get_lineno(void)
 /* }}} */
 
 /* {{{ zend_ini_scanner_get_filename() */
-ZEND_COLD char *zend_ini_scanner_get_filename(void)
+ZEND_COLD const char *zend_ini_scanner_get_filename(void)
 {
 	return ini_filename ? ZSTR_VAL(ini_filename) : "Unknown";
 }