Improve illegal offset error messages (#10504)

Co-authored-by: Marcos Marcolin <[email protected]>

Author: marcosmarcolin

Zend/tests/036.phpt

@@ -11,4 +11,4 @@ try {
 
 ?>
 --EXPECT--
-Illegal offset type
+Cannot access offset of type object on array

Zend/tests/038.phpt

@@ -11,4 +11,4 @@ try {
 
 ?>
 --EXPECT--
-Illegal offset type
+Cannot access offset of type object on array

Zend/tests/assign_dim_obj_null_return.phpt

@@ -72,12 +72,12 @@ test();
 ?>
 --EXPECT--
 Cannot add element to the array as the next element is already occupied
-Illegal offset type
-Illegal offset type
+Cannot access offset of type array on array
+Cannot access offset of type object on array
 Cannot use a scalar value as an array
 Cannot add element to the array as the next element is already occupied
-Illegal offset type
-Illegal offset type
+Cannot access offset of type array on array
+Cannot access offset of type object on array
 Cannot use a scalar value as an array
 Attempt to assign property "foo" on true
 Attempt to assign property "foo" on true

Zend/tests/bug79790.phpt

@@ -8,7 +8,7 @@ function b($a = array()[array ()]) {
 }
 ?>
 --EXPECTF--
-Fatal error: Uncaught TypeError: Illegal offset type in %s:%d
+Fatal error: Uncaught TypeError: Cannot access offset of type array on array in %s:%d
 Stack trace:
 #0 %s(%d): b()
 #1 {main}

Zend/tests/bug79947.phpt

@@ -12,6 +12,6 @@ try {
 var_dump($array);
 ?>
 --EXPECT--
-Illegal offset type
+Cannot access offset of type array on array
 array(0) {
 }

Zend/tests/bug80781.phpt

@@ -25,7 +25,7 @@ if (isset($array[$data]) or getPlugin($data)) {
 
 ?>
 --EXPECTF--
-Fatal error: Uncaught TypeError: Illegal offset type in isset or empty in %s:%d
+Fatal error: Uncaught TypeError: Cannot access offset of type array in isset or empty in %s:%d
 Stack trace:
 #0 {main}
   thrown in %s on line %d

Zend/tests/constant_expressions_invalid_offset_type_error.phpt

@@ -8,7 +8,7 @@ const C2 = [C1, [] => 1];
 
 ?>
 --EXPECTF--
-Fatal error: Uncaught TypeError: Illegal offset type in %s:%d
+Fatal error: Uncaught TypeError: Cannot access offset of type array on array in %s:%d
 Stack trace:
 #0 {main}
   thrown in %s on line %d

Zend/tests/gh8821.phpt

@@ -15,7 +15,7 @@ new Bravo();
 
 ?>
 --EXPECTF--
-Fatal error: Uncaught TypeError: Illegal offset type in %sgh8821.php:8
+Fatal error: Uncaught TypeError: Cannot access offset of type object on array in %sgh8821.php:8
 Stack trace:
 #0 %sgh8821.php(11): [constant expression]()
 #1 {main}

Zend/tests/illegal_offset_unset_isset_empty.phpt

@@ -22,6 +22,6 @@ try {
 
 ?>
 --EXPECT--
-Illegal offset type in unset
-Illegal offset type in isset or empty
-Illegal offset type in isset or empty
+Cannot access offset of type array in unset
+Cannot access offset of type array in isset or empty
+Cannot access offset of type array in isset or empty

Zend/tests/init_array_illegal_offset_type.phpt

@@ -12,4 +12,4 @@ try {
 }
 ?>
 --EXPECT--
-Illegal offset type
+Cannot access offset of type object on array