Fixed bug GH-9431: DateTime::getLastErrors() not returning false when no errors/warnings

For PHP 8.2 and later only.

Author: derickr

NEWS

@@ -17,6 +17,10 @@ PHP                                                                        NEWS
   . Fixed bug GH-9285 (Traits cannot be used in readonly classes).
     (kocsismate)
 
+- Date:
+  . Fixed bug GH-9431 (DateTime::getLastErrors() not returning false when no
+    errors/warnings). (Derick)
+
 - Opcache:
   . Fixed bug GH-9371 (Crash with JIT on mac arm64)
     (jdp1024/David Carlier)

ext/date/php_date.c

@@ -2269,7 +2269,11 @@ static void update_errors_warnings(timelib_error_container *last_errors) /* {{{
 		timelib_error_container_dtor(DATEG(last_errors));
 		DATEG(last_errors) = NULL;
 	}
-	DATEG(last_errors) = last_errors;
+	if (last_errors->warning_count || last_errors->error_count) {
+		DATEG(last_errors) = last_errors;
+	} else {
+		timelib_error_container_dtor(last_errors);
+	}
 } /* }}} */
 
 static void php_date_set_time_fraction(timelib_time *time, int microseconds)

ext/date/tests/bug51866.phpt

@@ -105,18 +105,7 @@ object(DateTime)#%d (3) {
   ["timezone"]=>
   string(%d) "%s"
 }
-array(4) {
-  ["warning_count"]=>
-  int(0)
-  ["warnings"]=>
-  array(0) {
-  }
-  ["error_count"]=>
-  int(0)
-  ["errors"]=>
-  array(0) {
-  }
-}
+bool(false)
 
 
 string(7) "Y-m-d +"
@@ -148,15 +137,4 @@ object(DateTime)#%d (3) {
   ["timezone"]=>
   string(%d) "%s"
 }
-array(4) {
-  ["warning_count"]=>
-  int(0)
-  ["warnings"]=>
-  array(0) {
-  }
-  ["error_count"]=>
-  int(0)
-  ["errors"]=>
-  array(0) {
-  }
-}
+bool(false)

ext/date/tests/date-lenient-create.phpt

@@ -113,37 +113,11 @@ DateTime Object
     [timezone_type] => 3
     [timezone] => UTC
 )
-Array
-(
-    [warning_count] => 0
-    [warnings] => Array
-        (
-        )
-
-    [error_count] => 0
-    [errors] => Array
-        (
-        )
-
-)
 ==
 DateTime Object
 (
     [date] => 2004-06-08 00:00:00.000000
     [timezone_type] => 3
     [timezone] => UTC
 )
-Array
-(
-    [warning_count] => 0
-    [warnings] => Array
-        (
-        )
-
-    [error_count] => 0
-    [errors] => Array
-        (
-        )
-
-)
 ==