Fix memory leak with failed SQLPrepare

NattyNarwhal · Girgias · commit a022ec53bdad · 2023-09-02T23:00:06.000+01:00
Closes GH-12095 Signed-off-by: George Peter Banyard <girgias@php.net>
diff --git a/NEWS b/NEWS
@@ -18,6 +18,9 @@ PHP                                                                        NEWS
   . Fixed bug GH-10270 (Invalid error message when connection via SSL fails:
     "trying to connect via (null)"). (Kamil Tekiela)
 
+- ODBC:
+  . Fixed memory leak with failed SQLPrepare. (NattyNarwhal)
+
 - SPL:
   . Fixed bug GH-11972 (RecursiveCallbackFilterIterator regression in 8.1.18).
     (nielsdos)
diff --git a/ext/odbc/php_odbc.c b/ext/odbc/php_odbc.c
@@ -923,6 +923,7 @@ PHP_FUNCTION(odbc_prepare)
 			break;
 		default:
 			odbc_sql_error(conn, result->stmt, "SQLPrepare");
+			efree(result);
 			RETURN_FALSE;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -923,6 +923,7 @@ PHP_FUNCTION(odbc_prepare)`
`923`	`923`	`break;`
`924`	`924`	`default:`
`925`	`925`	`odbc_sql_error(conn, result->stmt, "SQLPrepare");`
	`926`	`+ efree(result);`
`926`	`927`	`RETURN_FALSE;`
`927`	`928`	`}`
`928`	`929`