add compat stuff for function attributes

remicollet · remicollet · commit aa702c54591b · 2022-08-18T13:46:55.000+02:00
diff --git a/build/gen_stub.php b/build/gen_stub.php
@@ -3997,8 +3997,14 @@ static function (FuncInfo $funcInfo) use ($fileInfo, &$generatedFunctionDeclarat
         }
     }
 
+    $php82MinimumCompatibility = $fileInfo->generateLegacyArginfoForPhpVersionId === null || $fileInfo->generateLegacyArginfoForPhpVersionId >= PHP_82_VERSION_ID;
+
     if ($fileInfo->generateClassEntries) {
-        $attributeInitializationCode = generateAttributeInitialization($fileInfo->funcInfos, $allConstInfos, null);
+        if ($attributeInitializationCode = generateAttributeInitialization($fileInfo->funcInfos, $allConstInfos, null)) {
+            if (!$php82MinimumCompatibility) {
+                $attributeInitializationCode = "\n#if (PHP_VERSION_ID >= " . PHP_82_VERSION_ID . ")" . $attributeInitializationCode . "#endif\n";
+            }
+        }
 
         if ($attributeInitializationCode !== "" || !empty($fileInfo->constInfos)) {
             $code .= "\nstatic void register_{$stubFilenameWithoutExtension}_symbols(int module_number)\n";

Original file line number	Diff line number	Diff line change
`@@ -3997,8 +3997,14 @@ static function (FuncInfo $funcInfo) use ($fileInfo, &$generatedFunctionDeclarat`
`3997`	`3997`	`}`
`3998`	`3998`	`}`
`3999`	`3999`
	`4000`	`+ $php82MinimumCompatibility = $fileInfo->generateLegacyArginfoForPhpVersionId === null \|\| $fileInfo->generateLegacyArginfoForPhpVersionId >= PHP_82_VERSION_ID;`
	`4001`	`+`
`4000`	`4002`	`if ($fileInfo->generateClassEntries) {`
`4001`		`- $attributeInitializationCode = generateAttributeInitialization($fileInfo->funcInfos, $allConstInfos, null);`
	`4003`	`+ if ($attributeInitializationCode = generateAttributeInitialization($fileInfo->funcInfos, $allConstInfos, null)) {`
	`4004`	`+ if (!$php82MinimumCompatibility) {`
	`4005`	`+ $attributeInitializationCode = "\n#if (PHP_VERSION_ID >= " . PHP_82_VERSION_ID . ")" . $attributeInitializationCode . "#endif\n";`
	`4006`	`+ }`
	`4007`	`+ }`
`4002`	`4008`
`4003`	`4009`	`if ($attributeInitializationCode !== "" \|\| !empty($fileInfo->constInfos)) {`
`4004`	`4010`	`$code .= "\nstatic void register_{$stubFilenameWithoutExtension}_symbols(int module_number)\n";`