Fixed GH-10218: DateTimeZone fails to parse time zones that contain the "+" character

Author: derickr

NEWS

@@ -13,6 +13,8 @@ PHP                                                                        NEWS
 - Date:
   . Fixed bug GH-9891 (DateTime modify with unixtimestamp (@) must work like
     setTimestamp). (Derick)
+  . Fixed bug GH-10218 (DateTimeZone fails to parse time zones that contain the
+    "+" character). (Derick)
 
 - FPM:
   . Fixed bug GH-9981 (FPM does not reset fastcgi.error_header).

ext/date/lib/parse_date.c

@@ -1,4 +1,4 @@
-/* Generated by re2c 0.15.3 on Thu Dec  1 10:57:42 2022 */
+/* Generated by re2c 0.15.3 on Tue Jan 10 15:14:08 2023 */
 #line 1 "ext/date/lib/parse_date.re"
 /*
  * The MIT License (MIT)
@@ -761,7 +761,7 @@ static timelib_long timelib_lookup_abbr(const char **ptr, int *dst, char **tz_ab
 		(**ptr >= 'A' && **ptr <= 'Z') ||
 		(**ptr >= 'a' && **ptr <= 'z') ||
 		(**ptr >= '0' && **ptr <= '9') ||
-		**ptr == '/' || **ptr == '_' || **ptr == '-'
+		**ptr == '/' || **ptr == '_' || **ptr == '-' || **ptr == '+'
 	) {
 		++*ptr;
 	}

ext/date/lib/parse_date.re

@@ -759,7 +759,7 @@ static timelib_long timelib_lookup_abbr(const char **ptr, int *dst, char **tz_ab
 		(**ptr >= 'A' && **ptr <= 'Z') ||
 		(**ptr >= 'a' && **ptr <= 'z') ||
 		(**ptr >= '0' && **ptr <= '9') ||
-		**ptr == '/' || **ptr == '_' || **ptr == '-'
+		**ptr == '/' || **ptr == '_' || **ptr == '-' || **ptr == '+'
 	) {
 		++*ptr;
 	}

ext/date/tests/gh10218.phpt

@@ -0,0 +1,15 @@
+--TEST--
+Bug GH-10218 (DateTimeZone fails to parse time zones that contain the "+" character)
+--FILE--
+<?php
+var_dump(new DateTime('now', new DateTimeZone('Etc/GMT+1')));
+?>
+--EXPECTF--
+object(DateTime)#%d (%d) {
+  ["date"]=>
+  string(%d) "%s"
+  ["timezone_type"]=>
+  int(3)
+  ["timezone"]=>
+  string(9) "Etc/GMT+1"
+}