MYSQL_ATTR_USE_BUFFERED_QUERY is a bool attribute (#10320)

Author: kamil-tekiela

ext/pdo_mysql/mysql_driver.c

@@ -526,7 +526,7 @@ static int pdo_mysql_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_
 			break;
 
 		case PDO_MYSQL_ATTR_USE_BUFFERED_QUERY:
-			ZVAL_LONG(return_value, H->buffered);
+			ZVAL_BOOL(return_value, H->buffered);
 			break;
 
 		case PDO_ATTR_EMULATE_PREPARES:

ext/pdo_mysql/tests/bug68371.phpt

@@ -17,7 +17,7 @@ $attrs = array(
     // Extensive test: default value and set+get values
     PDO::ATTR_EMULATE_PREPARES		=> array(null, 1, 0),
     PDO::MYSQL_ATTR_DIRECT_QUERY	=> array(null, 0, 1),
-    PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => array(null, 0, 1),
+    PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => array(null, false, true),
 
     // Just test the default
     PDO::ATTR_AUTOCOMMIT			=> array(null),
@@ -73,7 +73,7 @@ OK
 int(0)
 OK
 OK
-int(1)
+bool(true)
 OK
 OK
 int(1)

ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt

@@ -61,7 +61,7 @@ MySQLPDOTest::skip();
             /* TODO - why is this a valid option if getAttribute() does not support it?! */
             PDO::ATTR_TIMEOUT 										=> false,
             PDO::ATTR_EMULATE_PREPARES						=> 1,
-            PDO::MYSQL_ATTR_USE_BUFFERED_QUERY		=> 1,
+            PDO::MYSQL_ATTR_USE_BUFFERED_QUERY		=> true,
             /* TODO getAttribute() does not handle it */
             PDO::MYSQL_ATTR_LOCAL_INFILE					=> false,
             /* TODO getAttribute() does not handle it */
@@ -144,8 +144,8 @@ MySQLPDOTest::skip();
         if ($db->getAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY))
             printf("[018] PDO::MYSQL_ATTR_DIRECT_QUERY should be off\n");
 
-        set_option_and_check(19, PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, 1, 'PDO::MYSQL_ATTR_USE_BUFFERED_QUERY');
-        set_option_and_check(20, PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, 0, 'PDO::MYSQL_ATTR_USE_BUFFERED_QUERY');
+        set_option_and_check(19, PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true, 'PDO::MYSQL_ATTR_USE_BUFFERED_QUERY');
+        set_option_and_check(20, PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, false, 'PDO::MYSQL_ATTR_USE_BUFFERED_QUERY');
 
         set_option_and_check(21, PDO::MYSQL_ATTR_LOCAL_INFILE, true, 'PDO::MYSQL_ATTR_LOCAL_INFILE');
         set_option_and_check(22, PDO::MYSQL_ATTR_LOCAL_INFILE, false, 'PDO::MYSQL_ATTR_LOCAL_INFILE');