Fixed #9165: strtotime translates a date-time with DST/non-DST hour differently based on default timezone

Author: derickr

NEWS

@@ -10,6 +10,10 @@ PHP                                                                        NEWS
   . Fixed bug GH-9447 (Invalid class FQN emitted by AST dump for new and class
     constants in constant expressions). (ilutov)
 
+- Date:
+  . Fixed bug GH-9165 (strtotime translates a date-time with DST/non-DST hour
+    differently based on default timezone). (Derick)
+
 - DOM:
   . Fixed bug #79451 (DOMDocument->replaceChild on doctype causes double free).
     (Nathan Freeman)

ext/date/tests/gh9165.phpt

@@ -0,0 +1,21 @@
+--TEST--
+GH-9165 (strtotime translates a date-time with DST/non-DST hour differently based on default timezone)
+--FILE--
+<?php
+date_default_timezone_set('America/Lower_Princes');
+echo strtotime("2018-10-28 01:00:00 Europe/London") . PHP_EOL;
+
+date_default_timezone_set('Europe/London');
+echo strtotime("2018-10-28 01:00:00 Europe/London"). PHP_EOL;
+
+date_default_timezone_set('America/Lower_Princes');
+echo strtotime("2018-10-28 04:00:00 Europe/London") . PHP_EOL;
+
+date_default_timezone_set('Europe/London');
+echo strtotime("2018-10-28 04:00:00 Europe/London"). PHP_EOL;
+?>
+--EXPECT--
+1540684800
+1540684800
+1540699200
+1540699200