Implement GH-8641: [Stream] STREAM_NOTIFY_COMPLETED over HTTP never emitted #10505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
force-pushed
the
completed-event
branch
from
736e3fc to
b3c23c2
Compare
Member
Author
|
Right... So the new test is failing because I didn't include my other PR fix in here... I'll wait until that other PR gets merged and keep this on draft for now, and then rebase it later. |
…r emitted This adds support for the completed event. Since the read handler could be entered twice towards the end of the stream we remember what the eof flag was before reading so we can emit the completed event when the flag changes to true.
Member
Author
|
I rebased this now that the PR this depends on has been merged. I think this is ready for review now. |
bukka
reviewed
May 8, 2023
bukka
reviewed
May 12, 2023
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
I think it looks reasonable. Just some minor comments.
Member
Author
|
Thx for the review, addressed the review comments and asked one question on one of your review comments. |
bukka
approved these changes
Jun 9, 2023
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
I just went again through all the logic and all looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-8641
This adds support for the completed event. Since the read handler could
be entered twice towards the end of the stream we remember what the eof
flag was before reading so we can emit the completed event when the flag
changes to true.
Please note that this depends on the fix in #10492 , otherwise this PR won't work properly.