Skip to content

Conversation

@MaxKellermann
Copy link
Contributor

1 is not a legal zend_result.

@MaxKellermann
Copy link
Contributor Author

Note that in PHP-8.1, ext/curl doesn't yet use zend_result; it was refactored in commit 5ad1b89 (@Girgias), but the wrong return value was not fixed in that commit.

@Girgias
Copy link
Member

Girgias commented Feb 21, 2023

Those zend_ini changes feels like a bug I introduced in: fa8d9b1 where I should have used bool. Which didn't cause any issue because out of the only two cases where this function is used, only one checks the return value and explicitly checks for == 0.

@Girgias Girgias closed this in ed4dc39 Feb 21, 2023
@MaxKellermann MaxKellermann deleted the fix_zend_result branch February 21, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants