Skip to content

Fix 2 OpenSSL error handling bugs #10705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ndossche wants to merge 2 commits into from
Closed

Fix 2 OpenSSL error handling bugs #10705

ndossche wants to merge 2 commits into from

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Feb 25, 2023

This PR contains 2 error handling fixes:

@ndossche
Add missing check for php_openssl_set_server_dh_param()
9e7962b
@ndossche
Fix incorrect error checking in php_openssl_set_server_dh_param()
15f3e56 
SSL_CTX_set_tmp_dh() and SSL_CTX_set0_tmp_dh_pkey() return 1 on success
and 0 on error. But only < 0 was checked which means that errors were
never caught.
@ndossche ndossche changed the title Openssl error oopsies Fix 2 OpenSSL error handling bugs Feb 25, 2023
@devnexen devnexen closed this in b09be29 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen devnexen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndossche @devnexen