Add missing error check on i2d_PKCS12_bio() #10761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function returns 0 on error and 1 on success. The error case was not checked and the function therefore would've returned true. The only other caller of i2d_PKCS12_bio() in the file has a correct error check.
iluuu1994
approved these changes
Mar 3, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me, but I'd like Jakub to confirm. 🙂
bukka
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function returns 0 on error and 1 on success. The error case was not checked and the function therefore would've returned true. The only other caller of i2d_PKCS12_bio() in the file has a correct error check.
Found using an experimental static analyser I'm developing.