Add missing error checks on EVP_MD_CTX_create() and EVP_VerifyInit() #10762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good but would like to confirm with someone more accustomed to. |
bukka
reviewed
Mar 4, 2023
Member
|
Looks good, just that processed should be probably more verified... |
bukka
reviewed
Mar 4, 2023
The first one returns NULL on error, and the second one returns 0 on error. These weren't checked.
ndossche
force-pushed
the
fix-phar-init-checks
branch
from
af3cf8a to
45bc8f9
Compare
Member
Author
|
Thanks, updated. |
bukka
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first one returns NULL on error, and the second one returns 0 on error. These weren't checked.
Found using an experimental static analyser I'm developing.