Fix metaphone encode compiler warning #10788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: array subscript -65 is below array bounds of ‘const char[26]‘ [-Warray-bounds] Errors like these sometimes only appear with optimizations when inlining/look unrolling.
ndossche
approved these changes
Mar 5, 2023
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Thanks for looking into this. It looks good. and adding an assert is definitely a good idea in any case :)
|
|
||
|
|
||
| /* Note: these macros require an uppercase letter input! */ | ||
| #define ENCODE(c) (isalpha(c) ? _codes[((c) - 'A')] : 0) |
Member
There was a problem hiding this comment.
I guess the comment saying "macros" is strictly speaking incorrect right now, since we have a function too.
| static zend_always_inline char encode(char c) { | ||
| if (isalpha(c)) { | ||
| ZEND_ASSERT(c >= 'A' && c <= 'Z'); | ||
| return _codes[((c) - 'A')]; |
Member
There was a problem hiding this comment.
Also slightly stupid codestyle nit: we don't need the parens here anymore, but I don't really care as it doesn't matter anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning: array subscript -65 is below array bounds of ‘const char[26]‘ [-Warray-bounds]
Errors like these sometimes only appear with optimizations when inlining/loop unrolling.