ext/intl: breakiterator::setText returns false on failure. #10820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Mar 10, 2023
|
|
||
| /** @tentative-return-type */ | ||
| public function setText(string $text): ?bool {} // TODO return false instead of null in case of failure | ||
| public function setText(string $text): bool {} // TODO return false instead of null in case of failure |
devnexen
force-pushed
the
breakiterator_false
branch
from
40d9be4 to
3987cea
Compare
devnexen
force-pushed
the
breakiterator_false
branch
from
3987cea to
01d51d7
Compare
kocsismate
reviewed
Mar 28, 2023
Member
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
This LGTM because the return value change is not fundamental so that at least already existing loose comparisons continue to work
kocsismate
reviewed
Mar 28, 2023
| . datefmt_set_timezone (and its alias IntlDateformatter::setTimeZone) | ||
| now returns true on sucess, previously null was returned. | ||
| now returns true on success, previously null was returned. | ||
| . breakiterator::setText now returns false on failure, previously |
Member
There was a problem hiding this comment.
Suggested change
| . breakiterator::setText now returns false on failure, previously | |
| . IntlBreakIterator::setText() now returns false on failure, previously |
Function brances (()) in the upgrading file are sometimes omitted, sometimes not, but personally, I'd prefer to have them if possible.
Girgias
approved these changes
Mar 28, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Yeah this one is IMHO fine because null to false doesn't change a lot of expectation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.