ext/mysqli/pgsql: mysqli_fetch_*/pgsql_fetch_* raises ValueError on c… #10832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
raw_sqlapi_fetch_value_error
branch
2 times, most recently
from
145207c to
5a8ac73
Compare
Girgias
approved these changes
Mar 13, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
UPGRADING nit but LGTM otherwise!
Comment on lines
95
to
101
| - mysqli: | ||
| . mysqli_fetch_object raises a ValueError when the constructor_args argument | ||
| is non empty with the class not having constructor. | ||
|
|
||
| - PGSQL: | ||
| . pg_fetch_object raises a ValueError when the constructor_args argument | ||
| is non empty with the class not having constructor. | ||
|
|
Member
There was a problem hiding this comment.
Nit: just to clarify that it already was throwing.
Suggested change
| - mysqli: | |
| . mysqli_fetch_object raises a ValueError when the constructor_args argument | |
| is non empty with the class not having constructor. | |
| - PGSQL: | |
| . pg_fetch_object raises a ValueError when the constructor_args argument | |
| is non empty with the class not having constructor. | |
| - mysqli: | |
| . mysqli_fetch_object now raises a ValueError instead of an Exception when the constructor_args | |
| argument is non empty with the class not having constructor. | |
| - PGSQL: | |
| . pg_fetch_object now raises a ValueError instead of an Exception when the constructor_args | |
| argument is non empty with the class not having constructor. | |
…Error on constructor args error.
devnexen
force-pushed
the
raw_sqlapi_fetch_value_error
branch
from
5a8ac73 to
74a211b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onstructor args
error.