Fix GH-10834: exif_read_data() cannot read smaller stream wrapper chunk sizes #10924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunk sizes php_stream_read() may return less than the requested amount of bytes by design. This patch introduces a static function for exif which reads from the stream in a loop until all the requested bytes are read. Test was Co-authored-by: dotpointer
ndossche
force-pushed
the
fix-10834-attempt-2
branch
from
738cdc5 to
f1314a1
Compare
Member
|
I'll let @bukka judge this. :) |
bukka
reviewed
Apr 17, 2023
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
Looks good in general. Just few comments added.
Member
Author
|
Thanks for checking. |
bukka
reviewed
May 12, 2023
Member
Author
|
Thanks, addressed the review comments. |
bukka
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_stream_read() may return less than the requested amount of bytes by design. This patch introduces a static function for exif which reads from the stream in a loop until all the requested bytes are read.
Test was
Co-authored-by: dotpointer
This is attempt nr 2 at fixing this because the previous attempt modified the stream core code which was undesired.
cc'ing @Girgias & @bukka because they looked at the previous version of the patch.