Skip to content

Fix GH-11455: PHP 8.2 Segmentation fault with custom object date properties #11473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ndossche wants to merge 1 commit into from
Closed

Fix GH-11455: PHP 8.2 Segmentation fault with custom object date properties #11473

ndossche wants to merge 1 commit into from

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Jun 18, 2023

Closes GH-11455.

@ndossche ndossche requested a review from derickr June 18, 2023 11:43
@ndossche ndossche linked an issue Jun 18, 2023 that may be closed by this pull request
PHP 8.2 Segmentation fault on nesbot/carbon #11455
Closed
@ndossche ndossche changed the title Fix GH-11455: PHP 8.2 Segmentation fault on nesbot/carbon Fix GH-11455: PHP 8.2 Segmentation fault with custom object date properties Jun 18, 2023
iluuu1994
iluuu1994 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @nielsdos!

@ndossche ndossche closed this in 93becab Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees

No one assigned

Labels

Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP 8.2 Segmentation fault on nesbot/carbon

2 participants

@ndossche @iluuu1994