-
Notifications
You must be signed in to change notification settings - Fork 8k
zend_call_stack_get implementation for NetBSD. #11637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arnaud-lb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
ping :) |
|
Sorry, I missed your update earlier. This looks good to me, but I'm not a fan of the zend_call_stack_get_netbsd_vm() {
...
void *buf = malloc(...);
zend_call_stack_get_netbsd_vm_read(...);
free(buf);
...
} |
db68f77 to
7e50615
Compare
Despite being OpenBSD's predecessor, the approach is in fact a lot closer to Linux, at least in principle. We purposely avoid reading /proc/N/maps to be more future-proof.
unlike what I thought using the previous mapping like linux throws off the proper stack size leading to memory fault.
7e50615 to
690f7d6
Compare
arnaud-lb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Despite being OpenBSD's predecessor, the approach is in fact a lot closer to Linux, at least in principle. We purposely avoid reading /proc/N/maps to be more future-proof.