Implement DOMNode::getRootNode() #11693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jul 13, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
LGTM as the implementation is straight forward and what I would expect.
Comment on lines
+1829
to
+1830
| /* Unused now because we don't support the shadow DOM nodes. Options only influence shadow DOM nodes. */ | ||
| zval *options = NULL; |
Member
There was a problem hiding this comment.
Could you possibly specify this in the UPGRADING document so that one does not need to look at the source code while writing the new docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://dom.spec.whatwg.org/#dom-node-getrootnode