Skip to content

Fix GH-12186: segfault copying/cloning a finalized HashContext #12187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaxSem wants to merge 1 commit into from
Closed

Fix GH-12186: segfault copying/cloning a finalized HashContext #12187

MaxSem wants to merge 1 commit into from

Conversation

@MaxSem
Copy link
Contributor

@MaxSem MaxSem commented Sep 12, 2023

Closes #12186

@MaxSem MaxSem requested a review from dstogov as a code owner September 12, 2023 11:37
dstogov
dstogov reviewed Sep 13, 2023
View reviewed changes
Girgias
Girgias reviewed Sep 13, 2023
View reviewed changes
@Girgias
Copy link
Member

Girgias commented Sep 13, 2023

This is a bug fix and must target the PHP-8.1 branch

@MaxSem MaxSem changed the base branch from master to PHP-8.1 September 13, 2023 17:06
@MaxSem
Copy link
Contributor Author

MaxSem commented Sep 14, 2023

The failing test appears unrelated.

@ndossche ndossche self-assigned this Sep 16, 2023
@ndossche ndossche closed this in 10f5a06 Sep 16, 2023
@ndossche
Copy link
Member

ndossche commented Sep 16, 2023

Thank you @MaxSem ! Merged into 8.1 and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstogov dstogov dstogov left review comments

@Girgias Girgias Girgias approved these changes

Assignees

@ndossche ndossche

Labels

Extension: hash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault in hash_copy() on a finalized context

4 participants

@MaxSem @Girgias @ndossche @dstogov