Fix GH-12190: stream_context_create with address and port at 0. #12195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses therefore addresses like `0` passed. For the bindto's case where both ip and port are set as such, we discard the address binding.
devnexen
force-pushed
the
fix_stream_unconventional_ip_parsing
branch
from
1e951ab to
ce5bdfc
Compare
bukka
approved these changes
Sep 24, 2023
Member
There was a problem hiding this comment.
The fix looks correct (kind of confusing that bindto is actually just ip part and not the whole passed value - I needed to extra check the code for that...). Just shame that we need to use online test for this as it is not going to run in pipeline. Can't really think about better way to test it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses therefore addresses like
0passed.For the bindto's case where both ip and port are set as such, we discard the address binding.