Pass zend_string message to zend_error_cb #5639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is not quite right due to the way last_error_message is managed. We probably shouldn't be setting it when outside a request. |
Export a zend_error_zstr API for that purpose.
Avoid leaking the last error between persistent and per-request phases.
nikic
force-pushed
the
error-format-cleanup
branch
from
9140665 to
186a6a9
Compare
beberlei
approved these changes
May 29, 2020
Contributor
beberlei
left a comment
beberlei
left a comment
There was a problem hiding this comment.
This is a nice cleanup, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing format and va_args, pass a preformatted zend_string. This saves every user from doing the formatting themselves, often multiple times. It also allows reusing the same message, instead of duplicating it in various places.
cc @beberlei. This is inspired by #4555, as I really don't like that adding another place where we pass format/args and force people do another formatted print.