Killing ext/ereg with fire! #814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice~ |
Contributor
|
💯 |
Contributor
Author
|
@Majkl578 This is easier; remove it first and see what breaks :) |
Contributor
|
Yup, but it's not a correct workflow. Also, git rebase magic is pretty easy solution for reordering commits. ;) |
Contributor
Author
|
@Majkl578 I guess we're just going to have to agree to disagree then. |
ext/mbstring/tests/mb_split.phpt
Outdated
Member
There was a problem hiding this comment.
Superfluous check, PCRE is always enabled.
Contributor
Author
There was a problem hiding this comment.
Coming to think of it, the check for mbstring extension is kind of unnecessary as well :)
datibbaw
force-pushed
the
kill-ereg
branch
2 times, most recently
from
4684406 to
610ef5d
Compare
Contributor
Author
|
Merged into master with 86de796 |
Contributor
|
Reverted with 1981dd9 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements an earlier discussion on the mailing list to finally remove ereg altogether.