Fix lineno for all constant expressions

[iluuu1994]

Closes GH-8821

I'm not sure what the performance implications of the setjmp are for each iteration of zend_ast_evaluate, but if zend_ast_evaluate bails we could end up with a freed string in filename_override which would be bad.

[bwoebi]

I don't like the way this is fixed. In particular it overrides call site information.

Would it be possible to install a fake (execute_data) frame when evaluated instead? I.e. line 8 calls line 11? The fake function name for that frame could be something like "constant X" (or "constant someclass::X").

This also applies to #8124 (which initially looked good to me, but I overlooked the include).

[iluuu1994]

@bwoebi You're right, that would be more desirable.

The fake function name for that frame could be something like "constant X" (or "constant someclass::X").

That would certainly be good, although we have to go through all the cases that use zend_ast_evaluate and configure the appropriate function name (or actually push the fake call frame right there to show all frames for nested constants). I'll give this a shot, or fall back to a simpler solution (like just adding a single frame with the name "Constant expression").

[dstogov]

I also don't like a special case covered by EG(filename_override)/EG(lineno_override), but I think creating a fake call frame is going to be too complex for this problem. So it's better to keep this simple solution.

[iluuu1994]

I had another look. @bwoebi I added a frame to the trace so it doesn't get lost. Let me know if you think this is acceptable now. If now I'll at least fix the lineno on master that get lost in various places.

[iluuu1994]

@bwoebi Have you ever had time to review this? I'm happy closing this if either of you object.

[bwoebi]

@iluuu1994 I don't object to it :-)

[bwoebi]

Yes, please merge it :-)