QA - ftp_rawlist - check list return value #9012
Conversation
| @@ -1,7 +1,5 @@ | |||
| --TEST-- | |||
| Testing ftp_rawlist basic functionality | |||
| --CREDITS-- | |||
There was a problem hiding this comment.
I dont know if doing this was right honeslty ... I was told that --CREDITS-- was not suppose to be use anymore
There was a problem hiding this comment.
We usually do not remove already existing CREDITS, but in this case it might be okay. @carusogabriel, or do you object?
There was a problem hiding this comment.
I'm okay, no worries from my side on removing all mine CREDITS in tests :)
There was a problem hiding this comment.
We usually do not remove already existing CREDITS, but in this case it might be okay. @carusogabriel, or do you object?
That is what I thought but I was not sure, I will add it again, is ethically correct to keep them
| @@ -1,7 +1,5 @@ | |||
| --TEST-- | |||
| Testing ftp_rawlist basic functionality | |||
| --CREDITS-- | |||
There was a problem hiding this comment.
We usually do not remove already existing CREDITS, but in this case it might be okay. @carusogabriel, or do you object?
Co-authored-by: Christoph M. Becker <[email protected]>
|
Thank you! |
3 participants
I am not sure if is wort the effort honestly.
Extension: ftp
Function: ftp_rawlist
I pretend to generate a code coverage on the part that we generate the result list of entries as shown in the picture:
That picture was the result after my change (I lost the picture of before my change)
But I had to adjust server.inc file, using kind of like the same code used for the NLIST ftp command in the same file.
Thanks in advance.