Sockets disable zerocopy test on ppc based arch. #9081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Jul 21, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you! This looks good, except for the skipif message.
| die('skip SO_ZEROCOPY'); | ||
| } | ||
| if (strpos($arch, 'ppc') !== false || strpos($arch, 'powerpc') !== false) { | ||
| die('skip on powerpc arch'); |
Member
There was a problem hiding this comment.
That would print "reason: on powerpc arch". So it's probably better to reword to something like "skip not for powerpc arch".
Failure reported by alpine maintainers.
devnexen
force-pushed
the
disable_ppc_forzerocopy
branch
from
3dd627d to
b496ca3
Compare
cmb69
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure reported by alpine maintainers.