Merge #455 - Remove unused if

Pull-request: #455

Signed-off-by: William Desportes <[email protected]>

Author: williamdes

psalm-baseline.xml

@@ -191,9 +191,6 @@
     <InvalidArgument>
       <code><![CDATA[$options['breakOnParentheses']]]></code>
     </InvalidArgument>
-    <InvalidAttribute>
-      <code>\AllowDynamicProperties</code>
-    </InvalidAttribute>
     <MixedArrayOffset>
       <code><![CDATA[Parser::$statementParsers[$token->keyword]]]></code>
       <code><![CDATA[self::$allowedKeywords[$token->keyword]]]></code>
@@ -236,6 +233,9 @@
     <TypeDoesNotContainType>
       <code><![CDATA[empty($options['field'])]]></code>
     </TypeDoesNotContainType>
+    <UndefinedAttributeClass>
+      <code>\AllowDynamicProperties</code>
+    </UndefinedAttributeClass>
   </file>
   <file src="src/Components/ExpressionArray.php">
     <InvalidArgument>
@@ -255,9 +255,6 @@
       <code>$expr</code>
       <code>$expr</code>
     </PossiblyNullArgument>
-    <RedundantCondition>
-      <code>is_array($ret)</code>
-    </RedundantCondition>
   </file>
   <file src="src/Components/FunctionCall.php">
     <MixedOperand>
@@ -4917,9 +4914,6 @@
       <code>$built[$field]</code>
       <code><![CDATA[$parsedClauses[$token->value]]]></code>
     </InvalidArgument>
-    <InvalidAttribute>
-      <code>\AllowDynamicProperties</code>
-    </InvalidAttribute>
     <MethodSignatureMustProvideReturnType>
       <code>__toString</code>
     </MethodSignatureMustProvideReturnType>
@@ -4955,6 +4949,9 @@
     <TypeDoesNotContainType>
       <code>count($clauses) === 0</code>
     </TypeDoesNotContainType>
+    <UndefinedAttributeClass>
+      <code>\AllowDynamicProperties</code>
+    </UndefinedAttributeClass>
     <UnusedForeachValue>
       <code>$index</code>
     </UnusedForeachValue>

src/Components/ExpressionArray.php

@@ -12,7 +12,6 @@
 
 use function count;
 use function implode;
-use function is_array;
 use function preg_match;
 use function strlen;
 use function substr;
@@ -105,15 +104,12 @@ public static function parse(Parser $parser, TokensList $list, array $options =
         }
 
         --$list->idx;
-
-        if (is_array($ret)) {
-            $retIndex = count($ret) - 1;
-            if (isset($ret[$retIndex])) {
-                $expr = $ret[$retIndex]->expr;
-                if (preg_match('/\s*--\s.*$/', $expr, $matches)) {
-                    $found = $matches[0];
-                    $ret[$retIndex]->expr = substr($expr, 0, strlen($expr) - strlen($found));
-                }
+        $retIndex = count($ret) - 1;
+        if (isset($ret[$retIndex])) {
+            $expr = $ret[$retIndex]->expr;
+            if (preg_match('/\s*--\s.*$/', $expr, $matches)) {
+                $found = $matches[0];
+                $ret[$retIndex]->expr = substr($expr, 0, strlen($expr) - strlen($found));
             }
         }